Skip to content

core/tui: cap MCP concurrency + TUI exec live-tail and concise TurnDiff logging #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

core/tui: cap MCP concurrency + TUI exec live-tail and concise TurnDiff logging #2227

wants to merge 3 commits into from
+95 −39

Conversation

Xopoko
Copy link

@Xopoko Xopoko commented Aug 12, 2025

What

  • core: limit concurrent MCP server starts (3) with a quick backoff retry (~750ms) on failure.
  • core: limit concurrent tools/list requests (4).
  • tui: show live tail of ExecCommandOutputDelta in the status line.
  • tui: log concise TurnDiff summary (bytes/lines) instead of full unified diff.
  • tui: disable ANSI in file logs to reduce noise.

Why

  • Reduce startup storms/timeouts and log noise; provide visible progress on long‑running commands.

How

  • Semaphore caps around server start and list‑tools; small retry on init failure.
  • TUI surface: consume delta events to update status; replace full diff logs with size summary.

Before/After

  • Before: repetitive MCP timeouts; "silent" long exec; giant diff logs.
  • After: bounded concurrency with retry; live status tail; concise diff logging.

Tests

  • Full suite passes locally (cargo test, cargo clippy --tests, cargo fmt).

Risks

  • Caps may be too conservative/aggressive; retry delay tuneable.

DCO/CLA

  • Signed‑off‑by present on commits. Will sign CLA via comment on this PR.

@Xopoko
core: cap MCP starts and tools/list concurrency with quick backoff
36fb539 
- Limit server start concurrency (3) with 750ms retry\n- Limit tools/list concurrency (4)\n- Reduces startup storms and timeouts

tui: live-tail exec output + concise TurnDiff summary

- Show last non-empty line of stdout/stderr in status line\n- Log TurnDiff sizes instead of full unified diff in logs\n- Disable ANSI in file logs

Signed-off-by: Horoko <[email protected]>
@Xopoko
Copy link
Author

Xopoko commented Aug 12, 2025

I have read the CLA Document and I hereby sign the CLA

@Xopoko Xopoko marked this pull request as draft August 12, 2025 14:21
@Xopoko Xopoko marked this pull request as ready for review August 12, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Xopoko